Merge 'string sometimes used as identifier quoting' from Lâm Hoàng Phúc

penberg · web-flow · commit d77b76e75afa · 2025-09-02T18:34:43.000+03:00
fix #2886 (comment) 3244885481 Closes #2894
diff --git a/core/util.rs b/core/util.rs
@@ -58,7 +58,12 @@ impl RoundToPrecision for f64 {
 }
 
 // https://sqlite.org/lang_keywords.html
-const QUOTE_PAIRS: &[(char, char)] = &[('"', '"'), ('[', ']'), ('`', '`')];
+const QUOTE_PAIRS: &[(char, char)] = &[
+    ('"', '"'),
+    ('[', ']'),
+    ('`', '`'),
+    ('\'', '\''), // string sometimes used as identifier quoting
+];
 
 pub fn normalize_ident(identifier: &str) -> String {
     let quote_pair = QUOTE_PAIRS
diff --git a/testing/create_table.test b/testing/create_table.test
@@ -20,4 +20,11 @@ do_execsql_test_on_specific_db {:memory:} create_table_rowid_unique_regression_t
   create table u(x integer unique primary key);
   insert into u values (1),(2),(3);
   select * from u where x > 2;
-} {3}
+} {3}
+
+# https://github.com/tursodatabase/turso/issues/2886#issuecomment-3244885481
+do_execsql_test_on_specific_db {:memory:} create_table_with_empty_string_name {
+  create table ''('' INTEGER) strict;
+  insert into '' values(9);
+  select * from '';
+} {9}
