Fixed comparator used in check of better evaluation

trtikm · trtikm · commit e3b08c667350 · 2025-08-10T21:03:30.000+02:00
diff --git a/src/solver_impl.cpp b/src/solver_impl.cpp
@@ -179,9 +179,9 @@ void SolverImpl::process_output(std::vector<Evaluation> const& output_)
             best_io.output = output;
             return;
         }
-        else if (local::is_better_evaluation(comparator_at(last), round_constants.seed_output.at(last).function, output.at(last).function)
+        else if (local::is_better_evaluation(opposite(comparator_at(last)), round_constants.seed_output.at(last).function, output.at(last).function)
                     && (best_io.input.empty() ||
-                        local::is_better_evaluation(comparator_at(last), best_io.output.at(last).function, output.at(last).function)))
+                        local::is_better_evaluation(opposite(comparator_at(last)), best_io.output.at(last).function, output.at(last).function)))
         {
             best_io.input = best_io.candidate;
             best_io.output = output;

Original file line number	Diff line number	Diff line change
`@@ -179,9 +179,9 @@ void SolverImpl::process_output(std::vector<Evaluation> const& output_)`
`179`	`179`	`best_io.output = output;`
`180`	`180`	`return;`
`181`	`181`	`}`
`182`		`- else if (local::is_better_evaluation(comparator_at(last), round_constants.seed_output.at(last).function, output.at(last).function)`
	`182`	`+ else if (local::is_better_evaluation(opposite(comparator_at(last)), round_constants.seed_output.at(last).function, output.at(last).function)`
`183`	`183`	`&& (best_io.input.empty() \|\|`
`184`		`- local::is_better_evaluation(comparator_at(last), best_io.output.at(last).function, output.at(last).function)))`
	`184`	`+ local::is_better_evaluation(opposite(comparator_at(last)), best_io.output.at(last).function, output.at(last).function)))`
`185`	`185`	`{`
`186`	`186`	`best_io.input = best_io.candidate;`
`187`	`187`	`best_io.output = output;`