feat: Add REDIS_KEY_PREFIX to ALL redis calls #17040
AlbertDoesProgramming
started this conversation in
Ideas
Replies: 2 comments
-
PR welcome! |
Beta Was this translation helpful? Give feedback.
0 replies
-
Awesome I'll sort this week. Been wanting to start contributing so there's the kick to ha 😉 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Check Existing Issues
Problem Description
Following the change here issue-16979, I've tried to use the REDIS_KEY_PREFIX and ACLs to gate permissions for a given open-webui instance behind the key prefix. For example, the pseudo code below
The issue, is there are other places where redis is used in openwebui not covered by the previous change. For example, in tools.py:
and
These keys are not prefixed and so, openwebui will throw a permissions error like the following:
Desired Solution you'd like
Please ensure that these keys are also prefixed. I am not sure if there are any others which also may need prefixing - I have searched for all instances of Redis use in the codebase, and these seem to be the only ones left - but might be worth a sanity check.
Alternatives Considered
I can add this tool_servers key to my ACL but I don't think that's in the spirit of the previous changes. If there are any others I'd also have to keep adding these which again feels out of the spirit of the previous changes.
Additional Context
No response
Beta Was this translation helpful? Give feedback.
All reactions