-
-
Notifications
You must be signed in to change notification settings - Fork 32.9k
Closed
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.
Description
See joyeecheung#8 for a reference.
This might also be applicable to
Lines 116 to 120 in 50cfc6c
size_t json_length = package_config.raw_json.size(); | |
package_config.raw_json.append(simdjson::SIMDJSON_PADDING, ' '); | |
simdjson::padded_string_view json_view(package_config.raw_json.data(), | |
json_length, | |
package_config.raw_json.size()); |
There is another place where we are manually padding the buffer, but I am not so sure whether using simdjson::pad is better than the current handling. I'd suggest first time contributors to avoid it unless you can assess the impact between the current approach and using simdjson::pad
and find the latter to be preferrable.
node/src/inspector_profiler.cc
Lines 128 to 131 in 7215d9b
if (!StringViewToUTF8(message, | |
&message_utf8, | |
&message_utf8_length, | |
simdjson::SIMDJSON_PADDING)) { |
0hmX, CarlosEduR, TheOneTheOnlyJJ and WebVishnu
Metadata
Metadata
Assignees
Labels
c++Issues and PRs that require attention from people who are familiar with C++.Issues and PRs that require attention from people who are familiar with C++.good first issueIssues that are suitable for first-time contributors.Issues that are suitable for first-time contributors.