sqlite: handle ?NNN parameters as positional

geeksilva97 · targos · commit e2b6bdc640a0 · 2025-08-24T09:09:10.000+02:00
PR-URL: #59350 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
diff --git a/src/node_sqlite.cc b/src/node_sqlite.cc
@@ -1933,7 +1933,9 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {
   }
 
   for (int i = anon_start; i < args.Length(); ++i) {
-    while (sqlite3_bind_parameter_name(statement_, anon_idx) != nullptr) {
+    while (1) {
+      const char* param = sqlite3_bind_parameter_name(statement_, anon_idx);
+      if (param == nullptr || param[0] == '?') break;
       anon_idx++;
     }
 
diff --git a/test/parallel/test-sqlite-statement-sync.js b/test/parallel/test-sqlite-statement-sync.js
@@ -240,6 +240,36 @@ suite('StatementSync.prototype.run()', () => {
       stmt.run({ k: 3, v: 30 }), { changes: 1, lastInsertRowid: 3 }
     );
   });
+
+  test('SQLite defaults unbound ?NNN parameters', (t) => {
+    const db = new DatabaseSync(nextDb());
+    t.after(() => { db.close(); });
+    const setup = db.exec(
+      'CREATE TABLE data(key INTEGER PRIMARY KEY, val INTEGER NOT NULL) STRICT;'
+    );
+    t.assert.strictEqual(setup, undefined);
+    const stmt = db.prepare('INSERT INTO data (key, val) VALUES (?1, ?3)');
+
+    t.assert.throws(() => {
+      stmt.run(1);
+    }, {
+      code: 'ERR_SQLITE_ERROR',
+      message: 'NOT NULL constraint failed: data.val',
+      errcode: 1299,
+      errstr: 'constraint failed',
+    });
+  });
+
+  test('binds ?NNN params by position', (t) => {
+    const db = new DatabaseSync(nextDb());
+    t.after(() => { db.close(); });
+    const setup = db.exec(
+      'CREATE TABLE data(key INTEGER PRIMARY KEY, val INTEGER NOT NULL) STRICT;'
+    );
+    t.assert.strictEqual(setup, undefined);
+    const stmt = db.prepare('INSERT INTO data (key, val) VALUES (?1, ?2)');
+    t.assert.deepStrictEqual(stmt.run(1, 2), { changes: 1, lastInsertRowid: 1 });
+  });
 });
 
 suite('StatementSync.prototype.sourceSQL', () => {

Original file line number	Diff line number	Diff line change
`@@ -1933,7 +1933,9 @@ bool StatementSync::BindParams(const FunctionCallbackInfo<Value>& args) {`
`1933`	`1933`	`}`
`1934`	`1934`
`1935`	`1935`	`for (int i = anon_start; i < args.Length(); ++i) {`
`1936`		`- while (sqlite3_bind_parameter_name(statement_, anon_idx) != nullptr) {`
	`1936`	`+ while (1) {`
	`1937`	`+ const char* param = sqlite3_bind_parameter_name(statement_, anon_idx);`
	`1938`	`+ if (param == nullptr \|\| param[0] == '?') break;`
`1937`	`1939`	`anon_idx++;`
`1938`	`1940`	`}`
`1939`	`1941`