Skip to content

Commit b3af17c

Browse files
Milad Fatargos
authored andcommitted
deps: V8: cherry-pick 7b91e3e2cbaf
Original commit message: s390: use %r15 instead of %sp Some compilers do not recognize %sp and output: ``` error: invalid register ``` Change-Id: I2e1b64dd0e799a03afccbd12f5b2db17b3130e07 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6603554 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Reviewed-by: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#100576} Refs: v8/v8@7b91e3e PR-URL: #59485 Refs: nodejs/build#4091 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
1 parent 9b69baf commit b3af17c

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.25',
41+
'v8_embedder_string': '-node.26',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/src/heap/base/asm/s390/push_registers_asm.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,17 @@ asm(".text \n"
2121
"PushAllRegistersAndIterateStack: \n"
2222
// Push all callee-saved registers.
2323
// r6-r13, r14 and sp(r15)
24-
" stmg %r6, %sp, 48(%sp) \n"
24+
" stmg %r6, %r15, 48(%r15) \n"
2525
// Allocate frame.
26-
" lay %sp, -160(%sp) \n"
26+
" lay %r15, -160(%r15) \n"
2727
// Pass 1st parameter (r2) unchanged (Stack*).
2828
// Pass 2nd parameter (r3) unchanged (StackVisitor*).
2929
// Save 3rd parameter (r4; IterateStackCallback).
3030
" lgr %r5, %r4 \n"
3131
// Pass sp as 3rd parameter. 160+48 to point
3232
// to callee saved region stored above.
33-
" lay %r4, 208(%sp) \n"
33+
" lay %r4, 208(%r15) \n"
3434
// Call the callback.
3535
" basr %r14, %r5 \n"
36-
" lmg %r14,%sp, 272(%sp) \n"
36+
" lmg %r14,%r15, 272(%r15) \n"
3737
" br %r14 \n");

0 commit comments

Comments
 (0)