src: move shared_ptr objects in KeyObjectData

tniessen · targos · commit 3e1551d8456d · 2025-08-21T19:01:03.000+02:00
Since copying `shared_ptr` may involve costly atomic operations, explicitly move both `shared_ptr` objects that are passed to the private KeyObjectData constructor. PR-URL: #59472 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/crypto/crypto_keys.h b/src/crypto/crypto_keys.h
@@ -127,7 +127,7 @@ class KeyObjectData final : public MemoryRetainer {
   KeyObjectData(KeyType type,
                 std::shared_ptr<Mutex> mutex,
                 std::shared_ptr<Data> data)
-      : key_type_(type), mutex_(mutex), data_(data) {}
+      : key_type_(type), mutex_(std::move(mutex)), data_(std::move(data)) {}
 };
 
 class KeyObjectHandle : public BaseObject {
