Preserve videos in paragraphs #957
Description
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch @mozilla/readability@0.5.0 for the project I'm working on.
Here is the diff that solved my problem:
diff --git a/node_modules/@mozilla/readability/Readability.js b/node_modules/@mozilla/readability/Readability.js
index b745aa0..970538b 100644
--- a/node_modules/@mozilla/readability/Readability.js
+++ b/node_modules/@mozilla/readability/Readability.js
@@ -715,11 +715,12 @@ Readability.prototype = {
// Remove extra paragraphs
this._removeNodes(this._getAllNodesWithTag(articleContent, ["p"]), function (paragraph) {
var imgCount = paragraph.getElementsByTagName("img").length;
+ var videoCount = paragraph.getElementsByTagName("video").length;
var embedCount = paragraph.getElementsByTagName("embed").length;
var objectCount = paragraph.getElementsByTagName("object").length;
// At this point, nasty iframes have been removed, only remain embedded video ones.
var iframeCount = paragraph.getElementsByTagName("iframe").length;
- var totalCount = imgCount + embedCount + objectCount + iframeCount;
+ var totalCount = imgCount + videoCount + embedCount + objectCount + iframeCount;
return totalCount === 0 && !this._getInnerText(paragraph, false);
});If I don't apply this change, the video on this website will be removed.
Do you think we can open a PR to fix it?
This issue body was partially generated by patch-package.