Fix translating text in button menus

morethanwords · morethanwords · commit cde55a72cc7b · 2025-08-12T18:20:56.000+04:00
diff --git a/src/components/buttonMenuToggle.ts b/src/components/buttonMenuToggle.ts
@@ -97,6 +97,10 @@ export default function ButtonMenuToggle({
     closeTimeout = undefined;
   };
 
+  // * fix translation by deleting text elements on close
+  const canDeleteTextElementsOnClose = buttons.filter((button) => !button.textElement);
+  const previousButtons = buttons.slice();
+
   let element: HTMLElement, closeTimeout: number, tempId = 0;
   ButtonMenuToggleHandler({
     el: button,
@@ -115,6 +119,10 @@ export default function ButtonMenuToggle({
         return;
       }
 
+      const newButtons = filteredButtons.slice().filter((button) => !previousButtons.includes(button));
+      previousButtons.push(...newButtons);
+      canDeleteTextElementsOnClose.push(...newButtons.filter((button) => !button.textElement));
+
       const _element = element = await ButtonMenu({
         buttons: filteredButtons,
         listenerSetter
@@ -152,6 +160,7 @@ export default function ButtonMenuToggle({
           try {button.dispose?.();} catch{}
           button.element = undefined;
         });
+        canDeleteTextElementsOnClose.forEach((button) => delete button.textElement);
         element.remove();
       }, 300);
     }
