Skip to content

fix: Dates before 1000AD should use 4-digit years #1132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: Dates before 1000AD should use 4-digit years #1132

merged 1 commit into from
Apr 17, 2024

Conversation

c2nes
Copy link
Contributor

@c2nes c2nes commented Apr 16, 2024

This is required for compliance with RFC3339/ISO8401 and timestamps which do not comply will be rejected by Spanner.

Fixes #1131

@c2nes c2nes requested review from a team as code owners April 16, 2024 15:59
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/python-spanner API. labels Apr 16, 2024
@c2nes
fix: Dates before 1000AD should use 4-digit years
ea27e1e 
This is required for compliance with RFC3339/ISO8401 and timestamps
which do not comply will be rejected by Spanner.

Fixes googleapis#1131
@c2nes c2nes force-pushed the pre_1000ad_timestamps branch from 1f7c19b to ea27e1e Compare April 16, 2024 17:06
@c2nes c2nes changed the title Ensure timestamps before 1000AD use 4-digit years fix: Dates before 1000AD should use 4-digit years Apr 16, 2024
@surbhigarg92 surbhigarg92 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 17, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 17, 2024
@surbhigarg92 surbhigarg92 merged commit 0ef6565 into googleapis:main Apr 17, 2024
@release-please release-please bot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Assignees

@surbhigarg92 surbhigarg92

Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timestamps before 1000AD rejected in mutation API
3 participants
@c2nes @surbhigarg92 @yoshi-kokoro