Skip to content

fix: add google-auth as a direct dependency #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix: add google-auth as a direct dependency #1076

merged 1 commit into from
Feb 8, 2024

Conversation

mukund-ananthu
Copy link
Contributor

@mukund-ananthu mukund-ananthu commented Feb 8, 2024 •
edited
Loading

  1. One of the issues this solves is the test coverage failures in https://github.com/googleapis/python-pubsub/actions/runs/7836080724/job/21382924522?pr=1064
  2. pulling the google-auth dependency transitively through google-api-core so we decided to use the same google-auth version as google-api-core which is 2.14.1
    https://github.com/googleapis/python-api-core/blob/82c31184168d92a88ea570780082ab1176cfed53/setup.py#L34
  3. Reference PR: fix: add google-auth as a direct dependency python-bigquery-storage#740

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@mukund-ananthu mukund-ananthu requested review from a team as code owners February 8, 2024 21:46
@mukund-ananthu mukund-ananthu self-assigned this Feb 8, 2024
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Feb 8, 2024
@mukund-ananthu mukund-ananthu merged commit 5ce7301 into main Feb 8, 2024
@mukund-ananthu mukund-ananthu deleted the gauth branch February 8, 2024 22:47
@release-please release-please bot mentioned this pull request Feb 8, 2024
Merged
michaelpri10
michaelpri10 requested changes Feb 8, 2024
View reviewed changes
setup.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< 3.0.dev0 to match https://github.com/googleapis/python-api-core/blob/82c31184168d92a88ea570780082ab1176cfed53/setup.py#L34

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Existing change seems to be consistent with googleapis/python-bigquery-storage@56e8958 which also refers to https://github.com/googleapis/python-api-core/blob/82c31184168d92a88ea570780082ab1176cfed53/setup.py#L34 and the way the versions are mentioned for the other lines in the file.

Tagging @parthea to get his input on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpri10 michaelpri10 michaelpri10 requested changes

@hongalex hongalex hongalex approved these changes

@parthea parthea Awaiting requested review from parthea

@pradn pradn Awaiting requested review from pradn

@acocuzzo acocuzzo Awaiting requested review from acocuzzo

Assignees

@mukund-ananthu mukund-ananthu

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mukund-ananthu @hongalex @michaelpri10