Skip to content

feat: grpc keep alive settings #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 2, 2024
Merged

feat: grpc keep alive settings #2086

merged 11 commits into from
Aug 2, 2024

Conversation

surbhigarg92
Copy link
Contributor

This PR sets default grpc keep alive options for Spanner library

'grpc.keepalive_time_ms': 30000,
'grpc.keepalive_timeout_ms': 10000,

These settings can be over written by passing to spanner options

const spanner = new Spanner({ 
    'grpc.keepalive_time_ms': 30000,
    'grpc.keepalive_timeout_ms': 10000,
  });

@surbhigarg92 surbhigarg92 requested review from a team as code owners August 1, 2024 05:24
@alkatrivedi alkatrivedi self-requested a review August 1, 2024 06:15
@surbhigarg92 surbhigarg92 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 1, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 1, 2024
@olavloite olavloite changed the title chore: grpc keep alive settings feat: grpc keep alive settings Aug 1, 2024
@olavloite
Copy link
Contributor

I changed the title of the PR to feat: instead of chore:, because I think this should go into the release notes.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Aug 1, 2024
@surbhigarg92 surbhigarg92 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 2, 2024
@surbhigarg92 surbhigarg92 merged commit 7712c35 into googleapis:main Aug 2, 2024
16 checks passed
@release-please release-please bot mentioned this pull request Aug 2, 2024
Merged
@surbhigarg92 surbhigarg92 deleted the grpc_keepalive branch August 2, 2024 04:59
gcf-merge-on-green bot pushed a commit that referenced this pull request Aug 2, 2024
@release-please
chore(main): release 7.12.0 (#2088)
4ec1561 
🤖 I have created a release *beep* *boop*
---


## [7.12.0](https://togithub.com/googleapis/nodejs-spanner/compare/v7.11.0...v7.12.0) (2024-08-02)


### Features

* Grpc keep alive settings ([#2086](https://togithub.com/googleapis/nodejs-spanner/issues/2086)) ([7712c35](https://togithub.com/googleapis/nodejs-spanner/commit/7712c35be21863015bb709f5f89d9ef0bb656024))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@alkatrivedi alkatrivedi alkatrivedi approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@surbhigarg92 @olavloite @alkatrivedi