Skip to content

fix: move runtime dependencies from dev dependencies to dependencies #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 8, 2022
Merged

fix: move runtime dependencies from dev dependencies to dependencies #1704

merged 3 commits into from
Sep 8, 2022

Conversation

PerThoresson
Copy link
Contributor

Fixes #1701 🦕

@PerThoresson PerThoresson requested review from a team as code owners September 5, 2022 11:42
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Sep 5, 2022
@asthamohta asthamohta added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 8, 2022
@asthamohta asthamohta merged commit b2c1c0f into googleapis:main Sep 8, 2022
@release-please release-please bot mentioned this pull request Sep 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surbhigarg92 surbhigarg92 Awaiting requested review from surbhigarg92

1 more reviewer

@asthamohta asthamohta asthamohta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@surbhigarg92 surbhigarg92

Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime dependencies faulty declared as devDependencies.
4 participants
@PerThoresson @asthamohta @surbhigarg92 @yoshi-kokoro