fixes to address feedback

skuruppu · skuruppu · commit a32b39cfb4da · 2024-02-14T13:50:59.000+11:00
diff --git a/src/codec.ts b/src/codec.ts
@@ -257,7 +257,7 @@ export class PGOid extends WrappedNumber {
   value: string;
   constructor(value: string) {
     super();
-    this.value = value.toString();
+    this.value = value;
   }
   valueOf(): number {
     const num = Number(this.value);
diff --git a/system-test/spanner.ts b/system-test/spanner.ts
@@ -828,7 +828,7 @@ describe('Spanner', () => {
     });
 
     describe('oids', () => {
-      it('POSTGRESQL should read pgOid values', function (done) {
+      it('POSTGRESQL should read non-null pgOid values', function (done) {
         if (IS_EMULATOR_ENABLED) {
           this.skip();
         }
@@ -842,6 +842,21 @@ describe('Spanner', () => {
           done();
         });
       });
+
+      it('POSTGRESQL should read null pgOid values', function (done) {
+        if (IS_EMULATOR_ENABLED) {
+          this.skip();
+        }
+        PG_DATABASE.run('SELECT null::oid', (err, rows) => {
+          assert.ifError(err);
+          let queriedValue = rows[0][0].value;
+          if (rows[0][0].value) {
+            queriedValue = rows[0][0].value.value;
+          }
+          assert.strictEqual(queriedValue, null);
+          done();
+        });
+      });
     });
 
     describe('float64s', () => {

Original file line number	Diff line number	Diff line change
`@@ -257,7 +257,7 @@ export class PGOid extends WrappedNumber {`
`257`	`257`	`value: string;`
`258`	`258`	`constructor(value: string) {`
`259`	`259`	`super();`
`260`		`- this.value = value.toString();`
	`260`	`+ this.value = value;`
`261`	`261`	`}`
`262`	`262`	`valueOf(): number {`
`263`	`263`	`const num = Number(this.value);`