Skip to content

Conversation

amychisholm03
Copy link
Contributor

This is an amendment to PR #2019 which resolved issue #2018. I did not add the messaging.operation attribute to the correct place in the code; it is now set in a more logical spot: createAttributes. I also modified the tests to reflect this change.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Apr 23, 2025
@amychisholm03 amychisholm03 marked this pull request as ready for review April 23, 2025 18:57
@amychisholm03 amychisholm03 requested review from a team as code owners April 23, 2025 18:57
@feywind feywind changed the title fix: Set messaging.operation in createAttributes fix: set messaging.operation in createAttributes May 8, 2025
@feywind feywind added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 8, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 8, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2025
@feywind feywind added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 9, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 9, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2025
@feywind feywind merged commit b8d513a into googleapis:main May 9, 2025
14 of 15 checks passed
@amychisholm03 amychisholm03 deleted the otel-sem-convs-addendum branch May 12, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update native OTel to semantic conventions 1.24.0
4 participants