fix: don't crash if an already-drained/removed queue gets flushed again #1747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamalaboulhosn
approved these changes
Jun 8, 2023
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
🤖 I have created a release *beep* *boop* --- ## [3.7.1](https://togithub.com/googleapis/nodejs-pubsub/compare/v3.7.0...v3.7.1) (2023-06-08) ### Bug Fixes * Don't crash if an already-drained/removed queue gets flushed again ([#1747](https://togithub.com/googleapis/nodejs-pubsub/issues/1747)) ([52ea441](https://togithub.com/googleapis/nodejs-pubsub/commit/52ea441fee302aa6c400b58d4ecebbc96a2ea5ea)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just allows correct clean-up behaviour if OrderedQueue.publish() gets called more than once. This shouldn't usually happen, but it seems like the easiest fix for the race condition mentioned in the issue.
Fixes: #1746