Skip to content

feat: Enable setting up the timeout for queries #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2025
Merged

feat: Enable setting up the timeout for queries #178

merged 3 commits into from
Jul 21, 2025

Conversation

jordimas
Copy link
Contributor

@jordimas jordimas commented May 7, 2025

Fixes #170

@jordimas jordimas requested review from a team as code owners May 7, 2025 20:02
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/langchain-google-spanner-python API. label May 7, 2025
@jordi-mas-dj jordi-mas-dj mentioned this pull request May 7, 2025
Closed
gauravpurohit06
gauravpurohit06 approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@gauravpurohit06 gauravpurohit06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding it.

@jordi-mas-dj
Copy link

Rewrote commit message to pass Conventional Commits

jordimas added a commit to jordimas/langchain-google-spanner-python that referenced this pull request May 8, 2025
@jordimas
fix(graph): raise InvalidGQLGenerationError with intermediate_steps
868d365 
Fixes googleapis#178
@averikitsch averikitsch changed the title Enable setting up the timeout for queries feat: Enable setting up the timeout for queries May 13, 2025
@mtyin
Copy link
Collaborator

mtyin commented May 22, 2025

/gcbrun

@mtyin
Copy link
Collaborator

mtyin commented May 23, 2025

/gcbrun

@averikitsch
Copy link
Collaborator

/gcbrun

@averikitsch
Copy link
Collaborator

/gcbrun

@averikitsch averikitsch merged commit 1c5cf19 into googleapis:main Jul 21, 2025
11 of 13 checks passed
@release-please release-please bot mentioned this pull request Jul 21, 2025
Merged
averikitsch added a commit that referenced this pull request Jul 22, 2025
@jordimas @averikitsch
feat(graph): raise InvalidGQLGenerationError with intermediate_steps (#…
22f2158 
…175)

Fixes #178

Co-authored-by: Averi Kitsch <akitsch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtyin mtyin mtyin approved these changes

@averikitsch averikitsch averikitsch approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

@Yuan325 Yuan325 Yuan325 approved these changes

+1 more reviewer

@gauravpurohit06 gauravpurohit06 gauravpurohit06 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@gauravpurohit06 gauravpurohit06

Labels
api: spanner Issues related to the googleapis/langchain-google-spanner-python API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement timeout for the Spanner query
7 participants
@jordimas @jordi-mas-dj @mtyin @averikitsch @gauravpurohit06 @kurtisvg @Yuan325