fix: add missing span.end calls for AsyncTransactionManager #4012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AsyncTransactionManager did not end the span when the transaction was committed or rolled back. This caused the spans not to be collected and exported.
sakthivelmanii
approved these changes
Aug 8, 2025
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Aug 12, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `6.98.0` -> `6.98.1` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.1` -> `2.31.2` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.19` -> `2.32.20` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.19` -> `2.32.20` | | [software.amazon.awssdk:regions](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.19` -> `2.32.20` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.19` -> `2.32.20` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.19` -> `2.32.20` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.19` -> `2.32.20` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.19` -> `2.32.20` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.32.19` -> `2.32.20` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.98.1`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6981-2025-08-11) ##### Bug Fixes - Add missing span.end calls for AsyncTransactionManager ([#​4012](googleapis/java-spanner#4012)) ([1a4adb4](googleapis/java-spanner@1a4adb4)) - **deps:** Update the Java code generator (gapic-generator-java) to 2.61.0 ([8156ef3](googleapis/java-spanner@8156ef3)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.51.0 ([#​4013](googleapis/java-spanner#4013)) ([4e90c29](googleapis/java-spanner@4e90c29)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.31.2`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2312-2025-08-08) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.61.0 ([c7bd68d](googleapis/java-datastore@c7bd68d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.51.0 ([#​1936](googleapis/java-datastore#1936)) ([a25433f](googleapis/java-datastore@a25433f)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: f88ced4c9b50670c3696f8a7549f60823aa70811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AsyncTransactionManager did not end the span when the transaction was committed or rolled back. This caused the spans not to be collected and exported.