Skip to content

feat: remove grpclb #2760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 20, 2024
Merged

feat: remove grpclb #2760

merged 16 commits into from
Apr 20, 2024

Conversation

mohanli-ml
Copy link
Contributor

Remove attempt DirectPath gRPCLB by default in Spanner Java because:

  1. gRPCLB is being deprecated, and Spanner does not have any gRPCLB traffic;
  2. Attempt gRPCLB by default has known DNS amplifying issue, all: DNS request amplification with default settings google-cloud-go#7812.

@mohanli-ml mohanli-ml requested a review from a team as a code owner December 18, 2023 21:38
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Dec 18, 2023
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Dec 18, 2023
@codyoss
Copy link
Member

codyoss commented Apr 9, 2024

@rahul2393

@mohanli-ml
Copy link
Contributor Author

Friendly ping. Can we merge this PR? Golang has merged googleapis/google-cloud-go#9186 so I want to make sure Java and Go has the same behavior. Thanks!

@olavloite olavloite requested a review from rahul2393 April 18, 2024 08:59
@mohanli-ml mohanli-ml requested a review from a team as a code owner April 18, 2024 23:07
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Apr 18, 2024
@olavloite olavloite added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 20, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 20, 2024
@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2024
@olavloite olavloite merged commit 1df09d9 into googleapis:main Apr 20, 2024
@release-please release-please bot mentioned this pull request Apr 20, 2024
Merged
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 20, 2024
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 20, 2024
@release-please
chore(main): release 6.65.0 (#3037)
e3be384 
🤖 I have created a release *beep* *boop*
---


## [6.65.0](https://togithub.com/googleapis/java-spanner/compare/v6.64.0...v6.65.0) (2024-04-20)


### Features

* Remove grpclb ([#2760](https://togithub.com/googleapis/java-spanner/issues/2760)) ([1df09d9](https://togithub.com/googleapis/java-spanner/commit/1df09d9b9189c5527de91189a063ecc15779ac77))
* Support client-side hints for tags and priority ([#3005](https://togithub.com/googleapis/java-spanner/issues/3005)) ([48828df](https://togithub.com/googleapis/java-spanner/commit/48828df3489465bb53a18be50808fbd435f3e896)), closes [#2978](https://togithub.com/googleapis/java-spanner/issues/2978)


### Bug Fixes

* **deps:** Update the Java code generator (gapic-generator-java) to 2.39.0 ([#3001](https://togithub.com/googleapis/java-spanner/issues/3001)) ([6cec1bf](https://togithub.com/googleapis/java-spanner/commit/6cec1bf1bb44a52c62c2310447c6a068a88209ea))
* NullPointerException on AbstractReadContext.span ([#3036](https://togithub.com/googleapis/java-spanner/issues/3036)) ([55732fd](https://togithub.com/googleapis/java-spanner/commit/55732fd107ac1d3b8c16eee198c904d54d98b2b4))


### Dependencies

* Update dependency com.google.cloud:sdk-platform-java-config to v3.29.0 ([#3045](https://togithub.com/googleapis/java-spanner/issues/3045)) ([67a6534](https://togithub.com/googleapis/java-spanner/commit/67a65346d5a01d118d5220230e3bed6db7e79a33))
* Update dependency commons-cli:commons-cli to v1.7.0 ([#3043](https://togithub.com/googleapis/java-spanner/issues/3043)) ([9fea7a3](https://togithub.com/googleapis/java-spanner/commit/9fea7a30e90227e735ad3595f4ca58dfb1ca1b93))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@rahul2393 rahul2393 Awaiting requested review from rahul2393

Assignees

@rahul2393 rahul2393

Labels
api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohanli-ml @codyoss @olavloite @rahul2393