Skip to content

feat(spanner): add samples for fine grained access control #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 15, 2022
Merged

feat(spanner): add samples for fine grained access control #2172

merged 11 commits into from
Dec 15, 2022

Conversation

rahul2393
Copy link
Contributor

@rahul2393 rahul2393 commented Nov 23, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

EnableFineGrainedAccess sample requires service account to work, so skipping integration tests for the same.

@rahul2393 rahul2393 requested a review from a team as a code owner November 23, 2022 11:00
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Nov 23, 2022
@snippet-bot
Copy link

snippet-bot bot commented Nov 23, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner November 23, 2022 11:03
@rahul2393 rahul2393 requested review from rajatbhatta and ansh0l and removed request for ansh0l November 23, 2022 11:24
@rajatbhatta
Copy link
Contributor

rajatbhatta commented Nov 28, 2022 •
edited
Loading

@rahul2393: I think we should add integration tests for the samples similar to https://github.com/googleapis/java-spanner/pull/2007/files#diff-cbbf8310726971f9d351d2727d761558fcea52286bd9b86628e83e763f8b63f0. Please add @RunWith(JUnit4.class) to the class.

rajatbhatta
rajatbhatta reviewed Nov 28, 2022
View reviewed changes
rajatbhatta
rajatbhatta reviewed Dec 5, 2022
View reviewed changes
rajatbhatta
rajatbhatta reviewed Dec 5, 2022
View reviewed changes
rajatbhatta
rajatbhatta approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm in general, just a couple of comments. You can merge it once the tests pass post those changes.

@rajatbhatta rajatbhatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 15, 2022
@rahul2393 rahul2393 merged commit 77969e3 into main Dec 15, 2022
@rahul2393 rahul2393 deleted the add-fgac-samples branch December 15, 2022 08:00
@release-please release-please bot mentioned this pull request Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rajatbhatta rajatbhatta rajatbhatta approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@alicejli alicejli

Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rahul2393 @rajatbhatta @yoshi-kokoro @alicejli