Skip to content

Conversation

michaelpri10
Copy link
Contributor

@michaelpri10 michaelpri10 commented Mar 28, 2025

This adds retries on ack and modack operations when the failure does not have a metadata map. This also adds a small change to only check ack IDs that are in a specific modack batch and adds a StatusUtil helper method. Additionally, we will forget ack IDs when an ack or modack fails with a non-retryable error.

@michaelpri10 michaelpri10 requested a review from a team as a code owner March 28, 2025 01:37
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/java-pubsub API. labels Mar 28, 2025
@michaelpri10 michaelpri10 merged commit 00070b7 into googleapis:main Mar 31, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants