Skip to content

docs: Update emulator sample to create a topic and publish to it #2039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2024
Merged

docs: Update emulator sample to create a topic and publish to it #2039

merged 3 commits into from
Oct 3, 2024

Conversation

michaelpri10
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

If you write sample code, please follow the samples format.

@michaelpri10 michaelpri10 requested review from a team as code owners May 20, 2024 16:42
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented May 20, 2024

Here is the summary of changes.

You are about to add 1 region tag.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. labels May 20, 2024
@michaelpri10
Copy link
Contributor Author

michaelpri10 commented May 28, 2024 •
edited
Loading

Note that this report is in response to internal code sample feedback (312895180).

@michaelpri10 michaelpri10 requested a review from hongalex May 28, 2024 16:49
@michaelpri10 michaelpri10 merged commit 21d5cfc into googleapis:main Oct 3, 2024
21 checks passed
@michaelpri10 michaelpri10 deleted the emulator-sample branch October 3, 2024 17:21
@release-please release-please bot mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex approved these changes

Assignees

@minherz minherz

@hongalex hongalex

Labels
api: pubsub Issues related to the googleapis/java-pubsub API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelpri10 @hongalex @minherz