Skip to content

feat(spanner/spansql): add support for CREATE VIEW with SQL SECURITY DEFINER #8754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2024
Merged

feat(spanner/spansql): add support for CREATE VIEW with SQL SECURITY DEFINER #8754

merged 3 commits into from
Jan 30, 2024

Conversation

toga4
Copy link
Contributor

@toga4 toga4 commented Oct 21, 2023

This PR adds support for DEFINER security type in create view DDL.

CREATE VIEW vname SQL SECURITY DEFINER AS SELECT cname FROM tname;

Fixes #8661

@toga4 toga4 requested review from a team as code owners October 21, 2023 06:32
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the Spanner API. labels Oct 21, 2023
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Nov 20, 2023
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels Dec 20, 2023
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 30, 2024
@rahul2393 rahul2393 merged commit 5f156e8 into googleapis:main Jan 30, 2024
@release-please release-please bot mentioned this pull request Jan 30, 2024
Merged
@toga4 toga4 deleted the spansql-view-security-type branch April 25, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

+1 more reviewer

@SDorgan SDorgan SDorgan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. size: m Pull request size is medium. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spanner/SpanSQL: Support CREATE VIEW with Security Type DEFINER
4 participants
@toga4 @rahul2393 @SDorgan @kokoro-team