Skip to content

fix(pubsub/pstest): make invalid filter return error instead of panic #11087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2024
Merged

fix(pubsub/pstest): make invalid filter return error instead of panic #11087

merged 2 commits into from
Nov 7, 2024

Conversation

hongalex
Copy link
Member

@hongalex hongalex commented Nov 6, 2024

Fixes #11076

@hongalex hongalex requested review from shollyman and a team as code owners November 6, 2024 00:36
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Nov 6, 2024
@hongalex hongalex merged commit 45e1ce7 into googleapis:main Nov 7, 2024
8 checks passed
@release-please release-please bot mentioned this pull request Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feywind feywind feywind approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman is a code owner

Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub/pstest: panics when provided a bad filter creating a subscription
2 participants
@hongalex @feywind