fix(auth, apple): Move FirebaseAuth imports to implementation files #17607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ncooke3 - excellent work, thank you for this! 👍 |
russellwheatley
approved these changes
Aug 8, 2025
SelaseKay
approved these changes
Aug 8, 2025
Lyokone
approved these changes
Aug 8, 2025
gspencergoog
pushed a commit
to gspencergoog/flutterfire
that referenced
this pull request
Aug 14, 2025
…irebase#17607) * [Infra] Move FirebaseAuth imports to implementation files * Add module import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed are non-public headers that import the firebase-ios-sdk's FirebaseAuth module (a Swift module). Importing Swift modules into an Objective-C header is not really supported (e.g. https://forums.swift.org/t/swift-cant-see-objc-methods-that-include-package-symbols/65732).
Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?