Skip to content

fix(fdc): fix an issue where if null is set, an empty value was being sent #17373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

fix(fdc): fix an issue where if null is set, an empty value was being sent #17373

merged 1 commit into from
May 21, 2025

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented May 20, 2025 •
edited by Lyokone
Loading

When calling setInt on an optional type with null, an empty string is returned instead.

closes #17357

@maneesht maneesht requested review from Lyokone and cynthiajoan May 21, 2025 00:18
@cynthiajoan cynthiajoan changed the title Fix issue where if null is set, an empty value was being sent fix(fdc): fix an issue where if null is set, an empty value was being sent May 21, 2025
@Lyokone Lyokone merged commit 53320dc into main May 21, 2025
27 of 32 checks passed
@Lyokone Lyokone deleted the mtewani/fix-null-set-vals branch May 21, 2025 14:21
@firebase firebase locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

@Lyokone Lyokone Lyokone approved these changes

+2 more reviewers

@stephenarosaj stephenarosaj stephenarosaj approved these changes

@aashishpatil-g aashishpatil-g aashishpatil-g approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[firebase_data_connect]: Null Values stored as Empty Strings in DB
5 participants
@maneesht @cynthiajoan @Lyokone @stephenarosaj @aashishpatil-g