Multiple Bug Fixes (#2606)

salianifo · web-flow · commit 92f4241be417 · 2025-06-08T20:04:44.000+02:00
* Fix Play from Here

* Fix portrait update not awaiting change_character_portrait

* Fix audio loop default to true
diff --git a/addons/dialogic/Editor/Events/EventBlock/event_block.gd b/addons/dialogic/Editor/Events/EventBlock/event_block.gd
@@ -425,6 +425,6 @@ func _on_EventNode_gui_input(event:InputEvent) -> void:
 			popup.current_event = self
 			popup.popup_on_parent(Rect2(get_global_mouse_position(),Vector2()))
 			if resource.help_page_path == "":
-				popup.set_item_disabled(2, true)
+				popup.set_item_disabled(4, true)
 			else:
-				popup.set_item_disabled(2, false)
+				popup.set_item_disabled(4, false)
diff --git a/addons/dialogic/Modules/Audio/subsystem_audio.gd b/addons/dialogic/Modules/Audio/subsystem_audio.gd
@@ -99,7 +99,7 @@ func update_audio(channel_name:= "", path := "", settings_overrides := {}) -> vo
 	## TODO use .merged after dropping 4.2 support
 	var audio_settings: Dictionary = DialogicUtil.get_audio_channel_defaults().get(channel_name, {})
 	audio_settings.merge(
-		{"volume":0, "audio_bus":"", "fade_length":0.0, "loop":false, "sync_channel":""}
+		{"volume":0, "audio_bus":"", "fade_length":0.0, "loop":true, "sync_channel":""}
 	)
 	audio_settings.merge(settings_overrides, true)
 
diff --git a/addons/dialogic/Modules/Character/event_character.gd b/addons/dialogic/Modules/Character/event_character.gd
@@ -155,7 +155,7 @@ func _execute() -> void:
 			return
 
 		if set_portrait:
-			dialogic.Portraits.change_character_portrait(character, portrait, fade_animation, fade_length)
+			await dialogic.Portraits.change_character_portrait(character, portrait, fade_animation, fade_length)
 
 		dialogic.Portraits.change_character_extradata(character, extra_data)
 

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ func update_audio(channel_name:= "", path := "", settings_overrides := {}) -> vo`
`99`	`99`	`## TODO use .merged after dropping 4.2 support`
`100`	`100`	`var audio_settings: Dictionary = DialogicUtil.get_audio_channel_defaults().get(channel_name, {})`
`101`	`101`	`audio_settings.merge(`
`102`		`- {"volume":0, "audio_bus":"", "fade_length":0.0, "loop":false, "sync_channel":""}`
	`102`	`+ {"volume":0, "audio_bus":"", "fade_length":0.0, "loop":true, "sync_channel":""}`
`103`	`103`	`)`
`104`	`104`	`audio_settings.merge(settings_overrides, true)`
`105`	`105`