chore: do not sort export conditions (#5683)

graynorton · Rajdeepc · caseyisonit · web-flow · commit 962c08353b8c · 2025-08-14T16:13:33.000Z
* chore: update eslint configs

* chore: add explanatory comment

---------

Co-authored-by: Rajdeep Chandra &lt;rajrock38@gmail.com&gt;
Co-authored-by: Casey Eickhoff &lt;48574582+caseyisonit@users.noreply.github.com&gt;
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -16,6 +16,15 @@
             "extends": ["plugin:jsonc/recommended-with-jsonc"],
             "files": ["*.json"],
             "parser": "jsonc-eslint-parser",
+            "rules": {
+                "jsonc/sort-keys": ["warn"],
+                "notice/notice": "off"
+            }
+        },
+        {
+            "extends": ["plugin:jsonc/recommended-with-jsonc"],
+            "files": ["package.json"],
+            "parser": "jsonc-eslint-parser",
             "rules": {
                 "jsonc/sort-keys": [
                     "warn",
@@ -65,14 +74,18 @@
                             "cpu",
                             "publishConfig"
                         ],
-                        "pathPattern": ".*" // Hits the all properties
+                        "pathPattern": "^$" // Top-level properties
                     },
                     {
+                        /*
+                         * This rule excludes export conditions from alphabetical sorting.
+                         * Since node.js processes export conditions in order and chooses the
+                         * first match, they need to be ordered logically, not alphabetically.
+                         */
                         "order": { "type": "asc" },
-                        "pathPattern": ".*"
+                        "pathPattern": "^(?!exports\\[).*" // All properties except export conditions
                     }
-                ],
-                "notice/notice": "off"
+                ]
             }
         },
         {
diff --git a/packages/.eslintrc.json b/packages/.eslintrc.json
@@ -134,6 +134,15 @@
             "extends": ["plugin:jsonc/recommended-with-jsonc"],
             "files": ["*.json"],
             "parser": "jsonc-eslint-parser",
+            "rules": {
+                "jsonc/sort-keys": ["warn"],
+                "notice/notice": "off"
+            }
+        },
+        {
+            "extends": ["plugin:jsonc/recommended-with-jsonc"],
+            "files": ["package.json"],
+            "parser": "jsonc-eslint-parser",
             "rules": {
                 "jsonc/sort-keys": [
                     "warn",
@@ -183,14 +192,18 @@
                             "cpu",
                             "publishConfig"
                         ],
-                        "pathPattern": ".*" // Hits the all properties
+                        "pathPattern": "^$" // Top-level properties
                     },
                     {
+                        /*
+                         * This rule excludes export conditions from alphabetical sorting.
+                         * Since node.js processes export conditions in order and chooses the
+                         * first match, they need to be ordered logically, not alphabetically.
+                         */
                         "order": { "type": "asc" },
-                        "pathPattern": ".*"
+                        "pathPattern": "^(?!exports\\[).*" // All properties except export conditions
                     }
-                ],
-                "notice/notice": "off"
+                ]
             }
         }
     ]
diff --git a/tools/.eslintrc.json b/tools/.eslintrc.json
@@ -127,6 +127,15 @@
             "extends": ["plugin:jsonc/recommended-with-jsonc"],
             "files": ["*.json"],
             "parser": "jsonc-eslint-parser",
+            "rules": {
+                "jsonc/sort-keys": ["warn"],
+                "notice/notice": "off"
+            }
+        },
+        {
+            "extends": ["plugin:jsonc/recommended-with-jsonc"],
+            "files": ["package.json"],
+            "parser": "jsonc-eslint-parser",
             "rules": {
                 "jsonc/sort-keys": [
                     "warn",
@@ -176,14 +185,18 @@
                             "cpu",
                             "publishConfig"
                         ],
-                        "pathPattern": ".*" // Hits the all properties
+                        "pathPattern": "^$" // Top-level properties
                     },
                     {
+                        /*
+                         * This rule excludes export conditions from alphabetical sorting.
+                         * Since node.js processes export conditions in order and chooses the
+                         * first match, they need to be ordered logically, not alphabetically.
+                         */
                         "order": { "type": "asc" },
-                        "pathPattern": ".*"
+                        "pathPattern": "^(?!exports\\[).*" // All properties except export conditions
                     }
-                ],
-                "notice/notice": "off"
+                ]
             }
         }
     ]
