Update scripts to current standards #24029
Description
Description:
We want to get rid of those ancient SD2 scripts. We will provide sniffs to whoever is inclined to improve them.
Please make one PR for each boss, not full instances. If you have plans to make multiple requests i suggest you to make them in a way that we can merge multiple pull requests at once.
Expected behaviour:
Scripts are updated to current standards and checked with sniffs.
Progress
Eastern Kingdoms
| Instance | Encounter | Codestyle | Checked with sniff | Merged | Complete Instance |
|---|---|---|---|---|---|
| Alterac Valley | Vanndar | #25181 | yes | ||
| Molten Core | Golemagg | #25183 | yes | ||
| Magisters' Terrace | Priestess Delrissa |
Kalimdor
| Instance | Encounter | Codestyle | Checked with sniff | Merged | Complete Instance |
|---|---|---|---|---|---|
| Dustwallow Marsh outdoor | 8fa6f95 | ||||
| Feralas outdoor | 5cddcc7 | ||||
| Azuregos | #26392 | fe41744 |
Outland
| Instance | Encounter | Codestyle | Checked with sniff | Merged | Complete Instance |
|---|---|---|---|---|---|
| Black Temple | Black Temple | yes | yes |
Northrend
| Instance | Encounter | Codestyle | Checked with sniff | Merged | Complete Instance |
|---|---|---|---|---|---|
| Ahn'Kahet | Ahn'Kahet | ||||
| Herald Volazj | #25187 | yes | |||
| Azjol-Nerub | Azjol-Nerub | ||||
| Anub'Arak | #25192 | yes | |||
| Gundrak | Gundrak | ||||
| Slad'ran | #25180 | yes | |||
| Drakkari Colossus | #25182 | yes | |||
| Violet Hold | Violet Hold | d22dcd1 | yes | ||
| Cyanigosa | #26371 | 94299a3 | |||
| Utgarde Pinnacle | Utgarde Pinnacle | ||||
| Gortok Palehoof | #26370 | ba7f11c | |||
| Utgarde Keep | Utgarde Keep | ||||
| Ingvar | #26369 | 8d9f24b |
| Instance | Encounter | Codestyle | Checked with sniff | Merged | Complete Instance |
|---|---|---|---|---|---|
| Icecrown Citadel | Icecrown Citadel | yes | yes | ||
| Blood council | #25389 | yes | |||
| Lich King | #25396 | yes | |||
| Sindragosa | #25395 | yes | |||
| Professor Putricide | #25394 | yes | |||
| Valithria Dreamwalker | #25390 | yes | |||
| Festergut | #25391 | yes | |||
| Rotface | #25392 | yes | |||
| Lady Deathwhisper | #25393 | yes | |||
| Blood Queen Lana'thel | #25434 | yes | |||
| Deathbringer Saurfang | #25435 | yes | |||
| Lord Marrowgar | #25436 | yes | |||
| Gunship Battle | #25438 | yes | |||
| Icecrown Citadel scripts | #25439 | yes | |||
| Vault of archavon | Vault of archavon | ||||
| Vault of archavon | #26372 | 3ece1ee | yes | ||
| Naxxramas | Naxxramas | yes | |||
| Thaddius | #26391 | 07fe74b | |||
| Razuvious | #26389 | 5293506 | |||
| Sapphiron | #26390 | 2cbfb78 | |||
| Noth | #26387 | 7dc1d5c | |||
| Patchwerk | #26388 | 6f0bc11 | |||
| Maexxna | #26386 | cb82cde | |||
| Heigan | #26383 | d694086 | |||
| Kel'Thuzad | #26384 | ff4d9a8 | |||
| Loatheb | #26385 | fb39a3c | |||
| Grobbulus | #26382 | cc3ef7e | |||
| Gluth | #26380 | 44686c3 | |||
| Gothik | #26381 | 9c72ca2 | |||
| Four Horsemen | #26379 | 7ef0de8 | |||
| Faerlina | #26378 | 4d82c6a | |||
| Anub'Rekhan | #26377 | 1288203 |
Class scripts
| Class | Codestyle | Merged |
|---|---|---|
| Priest | 7cb9cd9 | |
| Shaman | b1e4d93 | |
| Warrior | 5715ed0 | |
| Hunter | 11ba46d |
Branch(es):
both
TC rev. hash/commit: