Skip to content

Commit 5ab1fc6

Browse files
initial commit (#854)
1 parent 3b90f15 commit 5ab1fc6

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/config.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ typedef enum {
2929
RM_CONFIG_COUNT,
3030
} RM_ConfigOption;
3131

32-
3332
static const char *RM_ConfigOptionToString(RM_ConfigOption option) {
3433
static const char *RM_ConfigOptionStrings[] = {
3534
[bf_error_rate] = "bf-error-rate",

src/rebloom.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -646,8 +646,8 @@ static int cfInsertCommon(RedisModuleCtx *ctx, RedisModuleString *keystr, RedisM
646646
if (status == SB_EMPTY && options->autocreate) {
647647
int err = CUCKOO_OK;
648648
if ((cf = cfCreate(key, options->capacity, rm_config.cf_bucket_size.value,
649-
rm_config.cf_max_iterations.value,
650-
rm_config.cf_expansion_factor.value, &err)) == NULL) {
649+
rm_config.cf_max_iterations.value, rm_config.cf_expansion_factor.value,
650+
&err)) == NULL) {
651651
if (err == CUCKOO_OOM) {
652652
RedisModule_ReplyWithError(ctx, "ERR Insufficient memory to create filter");
653653
} else {
@@ -1491,8 +1491,10 @@ int RedisModule_OnLoad(RedisModuleCtx *ctx, RedisModuleString **argv, int argc)
14911491
RedisModule_Log(ctx, "warning", "Error rate is capped at %f", BF_ERROR_RATE_CAP);
14921492
}
14931493

1494-
if (RM_RegisterConfigs(ctx) != REDISMODULE_OK ||
1495-
RedisModule_LoadConfigs(ctx) != REDISMODULE_OK) {
1494+
if (!RedisModule_RegisterStringConfig || !RedisModule_LoadConfigs) {
1495+
// nothing to do
1496+
} else if (RM_RegisterConfigs(ctx) != REDISMODULE_OK ||
1497+
RedisModule_LoadConfigs(ctx) != REDISMODULE_OK) {
14961498
return REDISMODULE_ERR;
14971499
}
14981500

0 commit comments

Comments
 (0)