Skip to content

Summary not showing open invoices [Fix included] #1322

@53r1k

Description

@53r1k

Title

The guest summary (start page) doesnt show open invoices correctly [Fix below]

Expected Behavior

When accessing the guest overview (/guest), the section for open invoices should show all currently open invoices. (Not the subpage you can access when clicking the navbar tab, but the one displayed on the overview page itself.

Current Behavior

When accessing the guest overview (/guest), it doesnt show open invoices under the corresponding section, unless there are also overdue invoices.

Steps to Reproduce

  1. Have a client/guest user that has no overdue invoices, but at least one open invoice
  2. Log in with that client/guest
  3. On the main page, (/guest) you should see that the open invoice(s) are not displayed
  4. Create an overdue invoice
  5. now the open invoice(s) are displayed

Screenshots (Optional)

I cannot upload files to this field. See Context field for screenshots.

Possible Solution (Optional)

The issue is very simple and i fixed it locally. I really appreciate the work you guys put into OSS, and I find it exaggerated to open a PR for a simple one-word-fix.

The issue lies in: application/modules/guest/views/index.php at line 51 (on current Development branch):
Image
This checks for overdue invoices instead of open invoices for displaying the open invoices. Simply changing the "if ($overdue_invoices)" to "if ($open_invoices)" fixed the issue for me.

Context (Environment)

Note: I have system settings set to german, and chaning the client/guests language to english somehow didnt change the language away from system default (german). (maybe another bug, or simply weird caching). My bug should really not be language-specific, though. (Dont worry about confidentiality, its a test user)

Screenshot 1; 1 open invoice, no overdue invoices (Open invoices should show under "Offene Rechnungen":

Image

Screenshot 2; 1 open invoice, 1 overdue invoice (Overdue invoices = Überfällige Rechnungen):

Image

Failure Logs (Optional)

No response

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions