improved ui performance

mrDIMAS · mrDIMAS · commit f4ae5fe4db05 · 2025-08-31T19:55:25.000+03:00
diff --git a/fyrox-ui/src/control.rs b/fyrox-ui/src/control.rs
@@ -28,6 +28,7 @@ use crate::{
 };
 use fyrox_core::define_as_any_trait;
 
+use fyrox_core::algebra::Matrix3;
 use std::{
     any::Any,
     ops::{Deref, DerefMut},
@@ -266,7 +267,12 @@ pub trait Control:
     /// for [`DrawingContext`] for more info.
     fn draw(&self, #[allow(unused_variables)] drawing_context: &mut DrawingContext) {}
 
-    fn on_visual_transform_changed(&self) {}
+    fn on_visual_transform_changed(
+        &self,
+        #[allow(unused_variables)] old_transform: &Matrix3<f32>,
+        #[allow(unused_variables)] new_transform: &Matrix3<f32>,
+    ) {
+    }
 
     /// The same as [`Self::draw`], but it runs after all descendant widgets are rendered.
     fn post_draw(&self, #[allow(unused_variables)] drawing_context: &mut DrawingContext) {}
diff --git a/fyrox-ui/src/inspector/editors/texture_slice.rs b/fyrox-ui/src/inspector/editors/texture_slice.rs
@@ -559,8 +559,13 @@ impl Control for TextureSliceEditorWindow {
         self.window.draw(drawing_context)
     }
 
-    fn on_visual_transform_changed(&self) {
-        self.window.on_visual_transform_changed()
+    fn on_visual_transform_changed(
+        &self,
+        old_transform: &Matrix3<f32>,
+        new_transform: &Matrix3<f32>,
+    ) {
+        self.window
+            .on_visual_transform_changed(old_transform, new_transform)
     }
 
     fn post_draw(&self, drawing_context: &mut DrawingContext) {
diff --git a/fyrox-ui/src/lib.rs b/fyrox-ui/src/lib.rs
@@ -1214,8 +1214,9 @@ impl UserInterface {
                     layout_transform * widget.render_transform
                 };
 
-                widget.visual_transform = visual_transform;
-                widget.on_visual_transform_changed();
+                let old_transform =
+                    std::mem::replace(&mut widget.visual_transform, visual_transform);
+                widget.on_visual_transform_changed(&old_transform, &visual_transform);
             }
         }
     }
diff --git a/fyrox-ui/src/text.rs b/fyrox-ui/src/text.rs
@@ -41,6 +41,7 @@ use crate::{
     BuildContext, Control, HorizontalAlignment, UiNode, UserInterface, VerticalAlignment,
 };
 
+use fyrox_core::algebra::Matrix3;
 use fyrox_graph::constructor::{ConstructorProvider, GraphNodeConstructor};
 use std::{
     cell::RefCell,
@@ -375,11 +376,17 @@ impl Control for Text {
         );
     }
 
-    fn on_visual_transform_changed(&self) {
-        self.formatted_text
-            .borrow_mut()
-            .set_super_sampling_scale(self.visual_max_scaling())
-            .build();
+    fn on_visual_transform_changed(
+        &self,
+        old_transform: &Matrix3<f32>,
+        new_transform: &Matrix3<f32>,
+    ) {
+        if old_transform != new_transform {
+            self.formatted_text
+                .borrow_mut()
+                .set_super_sampling_scale(self.visual_max_scaling())
+                .build();
+        }
     }
 
     fn handle_routed_message(&mut self, ui: &mut UserInterface, message: &mut UiMessage) {
diff --git a/fyrox-ui/src/text_box.rs b/fyrox-ui/src/text_box.rs
@@ -48,6 +48,7 @@ use crate::{
 };
 use copypasta::ClipboardProvider;
 
+use fyrox_core::algebra::Matrix3;
 use fyrox_core::some_or_return;
 use fyrox_graph::constructor::{ConstructorProvider, GraphNodeConstructor};
 use std::{
@@ -952,11 +953,17 @@ impl Control for TextBox {
             .build()
     }
 
-    fn on_visual_transform_changed(&self) {
-        self.formatted_text
-            .borrow_mut()
-            .set_super_sampling_scale(self.visual_max_scaling())
-            .build();
+    fn on_visual_transform_changed(
+        &self,
+        old_transform: &Matrix3<f32>,
+        new_transform: &Matrix3<f32>,
+    ) {
+        if old_transform != new_transform {
+            self.formatted_text
+                .borrow_mut()
+                .set_super_sampling_scale(self.visual_max_scaling())
+                .build();
+        }
     }
 
     fn draw(&self, drawing_context: &mut DrawingContext) {

Original file line number	Diff line number	Diff line change
`@@ -559,8 +559,13 @@ impl Control for TextureSliceEditorWindow {`
`559`	`559`	`self.window.draw(drawing_context)`
`560`	`560`	`}`
`561`	`561`
`562`		`- fn on_visual_transform_changed(&self) {`
`563`		`- self.window.on_visual_transform_changed()`
	`562`	`+ fn on_visual_transform_changed(`
	`563`	`+ &self,`
	`564`	`+ old_transform: &Matrix3<f32>,`
	`565`	`+ new_transform: &Matrix3<f32>,`
	`566`	`+ ) {`
	`567`	`+ self.window`
	`568`	`+ .on_visual_transform_changed(old_transform, new_transform)`
`564`	`569`	`}`
`565`	`570`
`566`	`571`	`fn post_draw(&self, drawing_context: &mut DrawingContext) {`
Original file line number	Diff line number	Diff line change
`@@ -1214,8 +1214,9 @@ impl UserInterface {`
`1214`	`1214`	`layout_transform * widget.render_transform`
`1215`	`1215`	`};`
`1216`	`1216`
`1217`		`- widget.visual_transform = visual_transform;`
`1218`		`- widget.on_visual_transform_changed();`
	`1217`	`+ let old_transform =`
	`1218`	`+ std::mem::replace(&mut widget.visual_transform, visual_transform);`
	`1219`	`+ widget.on_visual_transform_changed(&old_transform, &visual_transform);`
`1219`	`1220`	`}`
`1220`	`1221`	`}`
`1221`	`1222`	`}`