Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Fody/Costura
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5.2.0
Choose a base ref
...
head repository: Fody/Costura
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5.3.0
Choose a head ref
  • 4 commits
  • 3 files changed
  • 3 contributors

Commits on Apr 12, 2021

  1. Configuration menu
    Copy the full SHA
    7943c90 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. Use the assembly resolver from the module definition

    Use the IAssemblyResolver provided by the module definition itself instead of the default resolver when reading the Costura template with Cecil so that assembly references are properly resolved for .NET Framework assemblies, even when running from a .NET Core runtime (which is exactly what is happening when running the `dotnet msbuild` command).
    
    When using the default assembly resolver, bad assembly references would be added to a weaved .NET Framework assembly, for example `System.Private.CoreLib` would be added as an assembly reference, making the weaved executable crash at startup.
    
    Fixes #694
    0xced committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    3a33f85 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #696 from 0xced/fix-assembly-resolver

    Use the assembly resolver from the module definition
    GeertvanHorrik authored Apr 19, 2021
    Configuration menu
    Copy the full SHA
    bec34e3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    695ba2e View commit details
    Browse the repository at this point in the history
Loading