[Assets] Prevent crash of the assets compiler when an assembly cannot be fully loaded. (stride3d#2144)

Kryptos-FR · web-flow · commit 2a8b04c03a90 · 2024-02-23T19:58:08.000+01:00
Fixes stride3d#2140
diff --git a/sources/assets/Stride.Core.Assets/Compiler/AssetCompilerRegistry.cs b/sources/assets/Stride.Core.Assets/Compiler/AssetCompilerRegistry.cs
@@ -3,6 +3,7 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Linq;
 using System.Reflection;
 using Stride.Core;
@@ -181,7 +182,7 @@ private void RegisterAssembly(Assembly assembly)
         private void RegisterCompilersFromAssembly(Assembly assembly)
         {
             // Process Asset types.
-            foreach (var type in assembly.GetTypes())
+            foreach (var type in GetFullyLoadedTypes(assembly))
             {
                 // Only process Asset types
                 if (!typeof(IAssetCompiler).IsAssignableFrom(type) || !type.IsClass)
@@ -202,6 +203,21 @@ private void RegisterCompilersFromAssembly(Assembly assembly)
                     log.Error($"Unable to instantiate compiler [{compilerAttribute.TypeName}]", ex);
                 }
             }
+
+            // Taken from https://stackoverflow.com/questions/7889228/how-to-prevent-reflectiontypeloadexception-when-calling-assembly-gettypes
+            [DebuggerNonUserCode]
+            IEnumerable<Type> GetFullyLoadedTypes(Assembly assembly)
+            {
+                try
+                {
+                    return assembly.GetTypes();
+                }
+                catch (ReflectionTypeLoadException ex)
+                {
+                    log.Warning($"Could not load all types from assembly {assembly.FullName}", ex);
+                    return ex.Types.Where(t => t != null);
+                }
+            }
         }
 
         private void UnregisterAssembly(Assembly assembly)
